[Kernel] Add snapshot construction benchmarking specification #5339
+135
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (workloadSpec.getVersion() != null) { | ||
| builder.atVersion(workloadSpec.getVersion()); | ||
| } | ||
| return builder.build(engine); |
There was a problem hiding this comment.
Should you call snapshot.getVersion, or cast it to SnapshotImpl and then call .getMetadata or .getProtocol? and maybe even print it out as a simple validation? or is that out of scope?
There was a problem hiding this comment.
Given this is part of the inner loop of the benchmark, I want to avoid any logging. Moreover, due to repeat runs, logging this can actually get quite noisy
There was a problem hiding this comment.
I think one area where this type of logging can be introduced is in the executeAsTest when that eventually comes in.
scottsand-db
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This introduces the snapshot construction spec and workload runner. These are used to measure the time it takes to construct a snapshot and perform protocol & metadata phase.
The snapshot construction spec takes an optional version.
How was this patch tested?
Does this PR introduce any user-facing changes?